<html>
<head><meta charset="utf-8"><title>reverting the revert rust-lang/rustfix#156 · edition 2021 · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/index.html">edition 2021</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/reverting.20the.20revert.20rust-lang.2Frustfix.23156.html">reverting the revert rust-lang/rustfix#156</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="237184967"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/reverting%20the%20revert%20rust-lang/rustfix%23156/near/237184967" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/reverting.20the.20revert.20rust-lang.2Frustfix.23156.html#237184967">(May 03 2021 at 16:00)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="120518">@Eric Huss</span> does this gist accurately describe your view <a href="https://gist.github.com/nikomatsakis/d067b2ef324525eae510532d0dca325b">https://gist.github.com/nikomatsakis/d067b2ef324525eae510532d0dca325b</a> when it comes to <a href="https://github.com/rust-lang/rust/issues/53934">#53934</a>?</p>



<a name="237184983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/reverting%20the%20revert%20rust-lang/rustfix%23156/near/237184983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/reverting.20the.20revert.20rust-lang.2Frustfix.23156.html#237184983">(May 03 2021 at 16:00)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="310399">@Mara</span> <span aria-label="point up" class="emoji emoji-1f446" role="img" title="point up">:point_up:</span></p>



<a name="237185800"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/reverting%20the%20revert%20rust-lang/rustfix%23156/near/237185800" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/reverting.20the.20revert.20rust-lang.2Frustfix.23156.html#237185800">(May 03 2021 at 16:05)</a>:</h4>
<p>Yes, that looks accurate to me.</p>



<a name="237185898"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/reverting%20the%20revert%20rust-lang/rustfix%23156/near/237185898" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/reverting.20the.20revert.20rust-lang.2Frustfix.23156.html#237185898">(May 03 2021 at 16:06)</a>:</h4>
<p>might be good to link to <a href="https://github.com/rust-lang/rust/blob/c825bc431ee5b815847b9bab693c59c43986fc4b/compiler/rustc_lint_defs/src/lib.rs#L28-L30">https://github.com/rust-lang/rust/blob/c825bc431ee5b815847b9bab693c59c43986fc4b/compiler/rustc_lint_defs/src/lib.rs#L28-L30</a></p>



<a name="237185983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/reverting%20the%20revert%20rust-lang/rustfix%23156/near/237185983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/reverting.20the.20revert.20rust-lang.2Frustfix.23156.html#237185983">(May 03 2021 at 16:06)</a>:</h4>
<p>the second sentence at least ^^', not sure if the first one is still accurate considering the case where there are some non-machine applicable alternatives</p>



<a name="237186949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/reverting%20the%20revert%20rust-lang/rustfix%23156/near/237186949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/reverting.20the.20revert.20rust-lang.2Frustfix.23156.html#237186949">(May 03 2021 at 16:14)</a>:</h4>
<p>Yeah, i would refine to like...</p>



<a name="237186977"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/reverting%20the%20revert%20rust-lang/rustfix%23156/near/237186977" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/reverting.20the.20revert.20rust-lang.2Frustfix.23156.html#237186977">(May 03 2021 at 16:14)</a>:</h4>
<p>'won't change the semantics of the code'</p>



<a name="237186989"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/reverting%20the%20revert%20rust-lang/rustfix%23156/near/237186989" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/reverting.20the.20revert.20rust-lang.2Frustfix.23156.html#237186989">(May 03 2021 at 16:14)</a>:</h4>
<p>or "will correct to the only plausible semantics' ?</p>



<a name="237193296"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/reverting%20the%20revert%20rust-lang/rustfix%23156/near/237193296" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/reverting.20the.20revert.20rust-lang.2Frustfix.23156.html#237193296">(May 03 2021 at 17:01)</a>:</h4>
<p>I added a sentence like this:</p>
<blockquote>
<p>Those <code>MachineApplicable</code> edits must not depend on any other suggestions which are not <code>MachineApplicable</code> (in other words, i there are any <code>MachineApplicable</code> suggestions, there must be a single logical edit that consists of all <code>MachineApplicable</code> suggestions and no other suggestions).</p>
</blockquote>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>